Serious issue in backup / restore: Page 2 - Enhance Control Panel

Serious issue in backup / restore

Andreas

Oh i did not know it worked this way either. I assumed when you restored from backup, you are using those files only, and anything before is gone.
Explained why when I was doing some testing and broke a site, none of the backups worked,

cornflakes

I'm new to Enhance and I've been hearing great things about the backup system though I haven't had to use it yet. If I may chime in here real quick... Not deleting files that were not in a previous version is a big problem in that on occasion we roll back a site if it's been compromised with malware, and so if a site were to be infected but rolled back, the newly created backdoor files that the malware inevitably had created would still be there, and that's a pretty big deal.

JohnB

cornflakes not in a previous version is a big problem in that on occasion we roll back a site if it's been compromised with malware, and so if a site were to be infected but rolled back

Just FYI this isn't just Enhance. I've seen hosting provider's special panels behave the same way. Siteground for example. For this reason my first step in malware cleanup if it involves restoring a backup is to completely delete every folder and DB that is backed up. In this way I can confirm with my own eyes that everything is gone.

xyzulu

This behaviour should at least be documented. Has anyone specifically requested support to do this yet?

gmakhs

xyzulu i think the team needs to decide if they will revert to the way it was or not first

xyzulu

No harm in documenting it now. I’ll be honest, until this thread I wasn’t aware this is how it worked now. This isn’t, in my opinion, how a backup restore should work.

Edit: I've opened a ticket specifically suggesting this be documented asap.

JohnB

xyzulu No harm in documenting it now. I’ll be honest, until this thread I wasn’t aware this is how it worked now. This isn’t, in my opinion, how a backup restore should work.

Its not how it should work but Siteground's panel behaves the same way. My theory is that it uses less resources to restore. Ie just copy files that don't exist or are different from backup instead of deleting everything and restoring.

Deleting first will cause downtime unless the approach uses a temp folder which will temporarily double the site size.

When I ran my own solution before Enhance I used ZFS snapshots which can be restored instantly. There are options outside of ZFS filesystem too. Worked great for me but mabye it doesn't scale to thousands of sites on a single server like Enhance ran into with the BTRF backup filesystem.

dweb

To be really honest, it would be even better if the user was prompted to wipe or not before restoring.
Why? Well, let's say the user deleted an email and need to restore a backup, but he doesn't want to wipe the new emails.

Same for files, sometimes you want to fix something but doesn't want to delete new created files. In other panel you need to take a backup before the restore, then restore a previous backup and then manually recover those files from the backup prior to restore.

Best of both worlds: Prompt the user during the restore process.
Do you want to OVERWRITE or RESTORE TO THE BACKUP STATE?

Kosta

dweb yeah prompt seems best solution

george

dweb +1

rdbf

Why not just restore the same way the backup is made? Rsync it, and use the --delete option to delete only the files that aren't part of the backup. There's no reason to orphan files on the web server when restoring from a backup.

I'm not even sure it should be called 'restore backup' if it doesn't restore the previous state..... More like 'restore missing and changed files from a backup state' or something like that.

xyzulu

rdbf Why not just restore the same way the backup is made? Rsync it, and use the --delete option to delete only the files that aren't part of the backup

This!!

rdbf More like 'restore missing and changed files from a backup state' or something like that.

It’s more a merge now.

« Previous Page